Skip to content

fix(codex): avoid prompt and --base conflict in review mode#1449

Open
Gujiassh wants to merge 1 commit into
garrytan:mainfrom
Gujiassh:fix/codex-review-base-conflict
Open

fix(codex): avoid prompt and --base conflict in review mode#1449
Gujiassh wants to merge 1 commit into
garrytan:mainfrom
Gujiassh:fix/codex-review-base-conflict

Conversation

@Gujiassh
Copy link
Copy Markdown

@Gujiassh Gujiassh commented May 12, 2026

Summary

  • stop default codex review from passing a positional prompt together with --base, which Codex CLI 0.130.0+ rejects
  • keep plain diff reviews on native codex review base-branch mode and route custom-instruction reviews through codex exec with an explicit git diff against the base branch
  • regenerate the affected skill docs and refresh golden baselines/tests so the incompatibility stays covered

Testing

  • bun run gen:skill-docs --host all
  • bun test test/gen-skill-docs.test.ts test/skill-validation.test.ts test/host-config.test.ts

Closes #1428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/codex review broken on Codex CLI ≥ 0.130.0 — passes [PROMPT] + --base together, which the CLI now rejects

1 participant